-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mfmodel): fix budgetkey for transport models #2176
Conversation
this gives the following for synthetic valley
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine for now, but I wonder if we need a more general way to set up these model-specific parameters. I think GWE probably has "ENERGY BUDGET FOR ENTIRE MODEL"? I'd say that we should override the output property for each flopy model object, but those classes are dynamically created. Looks like there is some model-specific code in MF6Output that would also benefit from generalization. Don't think we need to rethink this now, but something to keep in mind as the number of model types increases.
budgetkey
param toMF6Output
and pass it down toMF6ListBudget
inMF6Output.__list()
MFModel.output
to setbudgetkey
to "MASS..." instead of volume for transport models