Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: use html for notebook download links #1976

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Oct 3, 2023

New notebook header will look like

Screenshot 2023-10-03 at 4 44 44 PM

The .py link is to the source script in this repo (ref corresponding to the docs version), the notebook link displays the .ipynb source which can be downloaded with ctrl+s (previously the link was an instant download).

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1976 (f199c85) into develop (1197094) will decrease coverage by 0.1%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           develop   #1976     +/-   ##
=========================================
- Coverage     72.7%   72.7%   -0.1%     
=========================================
  Files          257     257             
  Lines        57810   57809      -1     
=========================================
- Hits         42081   42074      -7     
- Misses       15729   15735      +6     

see 3 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review October 3, 2023 20:47
@wpbonelli wpbonelli merged commit 1eddf86 into modflowpy:develop Oct 4, 2023
21 checks passed
@wpbonelli wpbonelli deleted the nb-download branch October 4, 2023 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

notebooks: simplify .py/.ipynb download links
1 participant