fix(mbase): warn if duplicate pkgs or units #1964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
wpbonelli
commented
Sep 26, 2023
wpbonelli
commented
- close Adding Modpath7Sim for second time replaces, but does not trigger 'replace' warning #1817
- consistent with MFSimulation verbosity default
- specify category=UserWarning for warnings in mbase.py
Codecov Report
@@ Coverage Diff @@
## develop #1964 +/- ##
=======================================
Coverage 72.6% 72.7%
=======================================
Files 257 257
Lines 57801 57799 -2
=======================================
+ Hits 42018 42022 +4
+ Misses 15783 15777 -6
|
wpbonelli
force-pushed
the
mbase-warnings
branch
from
b0229c1
to
36aeeef
Compare
* for consistency with MFSimulation verbosity defaults * specify category=UserWarning for warnings in mbase.py
wpbonelli
force-pushed
the
mbase-warnings
branch
from
36aeeef
to
75298c5
Compare
jdhughes-usgs
approved these changes
Sep 26, 2023
wpbonelli
added a commit
that referenced
this pull request
Sep 30, 2023
* consistent with MFSimulation verbosity defaults * use category=UserWarning for mbase.py warnings * closes #1817
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.