Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix usgbcf #1959

Merged
merged 2 commits into from
Sep 22, 2023
Merged

Fix usgbcf #1959

merged 2 commits into from
Sep 22, 2023

Conversation

cnicol-gwlogic
Copy link
Contributor

@cnicol-gwlogic
fix(usg bcf) ksat util3d call --> util2d call
0389cee 
Signed-off-by: Chris Nicol <chris.nicol@groundwaterlogic.com>
@cnicol-gwlogic
doc(modflow/sfr2) add sfr2 channel_geometry_data to docstring
f8dbb40 
Signed-off-by: Chris Nicol <chris.nicol@groundwaterlogic.com>
@codecov
Copy link

codecov bot commented Sep 22, 2023 •
edited
Loading

Codecov Report

Merging #1959 (f8dbb40) into develop (9e9d730) will increase coverage by 0.0%.
The diff coverage is 0.0%.

@@           Coverage Diff           @@
##           develop   #1959   +/-   ##
=======================================
  Coverage     72.6%   72.6%           
=======================================
  Files          257     257           
  Lines        57812   57812           
=======================================
+ Hits         42009   42028   +19     
+ Misses       15803   15784   -19
Files Changed Coverage Δ
flopy/mfusg/mfusgbcf.py 80.4% <0.0%> (ø)
flopy/modflow/mfsfr2.py 87.5% <ø> (ø)

... and 4 files with indirect coverage changes

@cnicol-gwlogic cnicol-gwlogic mentioned this pull request Sep 22, 2023
Closed
langevin-usgs
langevin-usgs approved these changes Sep 22, 2023
View reviewed changes
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @cnicol-gwlogic!

@langevin-usgs langevin-usgs merged commit 06eefd7 into modflowpy:develop Sep 22, 2023
21 checks passed
wpbonelli pushed a commit that referenced this pull request Sep 30, 2023
@cnicol-gwlogic @wpbonelli
Fix usgbcf (#1959)
d2dbacb 
* fix(usg bcf) ksat util3d call --> util2d call

Signed-off-by: Chris Nicol <chris.nicol@groundwaterlogic.com>

* doc(modflow/sfr2) add sfr2 channel_geometry_data to docstring

Signed-off-by: Chris Nicol <chris.nicol@groundwaterlogic.com>

---------

Signed-off-by: Chris Nicol <chris.nicol@groundwaterlogic.com>
@wpbonelli wpbonelli mentioned this pull request Feb 1, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@langevin-usgs langevin-usgs langevin-usgs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Importing cross-sectional USG model results has 3 dimensional error
2 participants
@cnicol-gwlogic @langevin-usgs