Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(expired deprecation): remaining references to SpatialReference #1914

Merged
merged 2 commits into from
Aug 11, 2023

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Aug 10, 2023

This cleans-up a few remaining references to SpatialReference or related (e.g. "sr"). This extends beyond #1200 and #1892.

Details of changes:

  • Some related docstrings improved and expanded
  • Remove unused method _set_sr_coord_info from flopy/discretization/grid.py
  • Spatial metadata in flopy/modflow/mfdis.py was not actually ignored, but now it actually is ignored and removed, as this should be in classic NAM files

Note that these changes are not related to flopy.mf6.utils.reference.SpatialReference, which is not deprecated.

@codecov
Copy link

codecov bot commented Aug 10, 2023

Codecov Report

Merging #1914 (56a256a) into develop (99f680f) will increase coverage by 0.0%.
The diff coverage is 57.1%.

@@           Coverage Diff           @@
##           develop   #1914   +/-   ##
=======================================
  Coverage     72.5%   72.6%           
=======================================
  Files          257     257           
  Lines        56279   56210   -69     
=======================================
- Hits         40854   40841   -13     
+ Misses       15425   15369   -56     
Files Changed Coverage Δ
flopy/discretization/grid.py 76.0% <ø> (+0.6%) ⬆️
flopy/mbase.py 69.6% <ø> (+0.2%) ⬆️
flopy/modflow/mfdis.py 91.9% <ø> (+7.4%) ⬆️
flopy/modflow/mfsfr2.py 87.5% <ø> (ø)
flopy/mt3d/mt.py 72.6% <ø> (+0.4%) ⬆️
flopy/pakbase.py 81.5% <ø> (+0.1%) ⬆️
flopy/plot/plotutil.py 53.2% <ø> (ø)
flopy/utils/binaryfile.py 81.2% <ø> (+0.4%) ⬆️
flopy/utils/reference.py 90.9% <ø> (ø)
flopy/export/shapefile_utils.py 83.4% <57.1%> (-0.2%) ⬇️

... and 1 file with indirect coverage changes

flopy/mbase.py Outdated Show resolved Hide resolved
flopy/mbase.py Outdated Show resolved Hide resolved
@wpbonelli wpbonelli merged commit ed3a0cd into modflowpy:develop Aug 11, 2023
21 checks passed
@mwtoews mwtoews deleted the dep-spatialreference branch August 11, 2023 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants