Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(dependencies): require pandas>=2.0.0 #1887

Merged
merged 1 commit into from
Aug 1, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Jul 31, 2023

Last #1788 was discussed (May 2023) it was proposed to wait one more release cycle before adding pandas as a core requirement, especially since pandas v2 came out in early April. In view of recent effort to optimize flopy file IO, now may be a good time. Some work underway to support MF6 PRT could also be simplified if pandas were present

  • Add pandas>=2.0.0 as a core dependency
  • Replace optional imports with standard imports
  • Update docstrings (remove "if available" language)
  • Remove alternative logic for pandas < 1.3.0 from sfroutputfile.py
  • Remove requires_pkg("pandas") from autotests
  • Update autotests to always test pandas path (where applicable)
  • Remove pandas entries from flopy_method_dependencies.md

If support should be maintained for older pandas I can remove the >=2 constraint and restore sfroutputfile.py

@codecov
Copy link

codecov bot commented Jul 31, 2023

Codecov Report

Merging #1887 (ac77a9b) into develop (7931112) will increase coverage by 0.0%.
The diff coverage is 93.3%.

@@           Coverage Diff           @@
##           develop   #1887   +/-   ##
=======================================
  Coverage     72.2%   72.2%           
=======================================
  Files          257     257           
  Lines        56508   56502    -6     
=======================================
+ Hits         40841   40842    +1     
+ Misses       15667   15660    -7     
Files Changed Coverage Δ
flopy/utils/utl_import.py 68.1% <ø> (ø)
flopy/utils/sfroutputfile.py 76.6% <75.0%> (+1.2%) ⬆️
flopy/export/metadata.py 23.3% <100.0%> (+0.8%) ⬆️
flopy/mf6/utils/binaryfile_utils.py 10.6% <100.0%> (+0.4%) ⬆️
flopy/mf6/utils/mfobservation.py 13.5% <100.0%> (+0.4%) ⬆️
flopy/modflow/mfsfr2.py 87.5% <100.0%> (+<0.1%) ⬆️
flopy/modpath/mp6sim.py 84.1% <100.0%> (ø)
flopy/utils/flopy_io.py 75.4% <100.0%> (ø)
flopy/utils/mflistfile.py 71.3% <100.0%> (ø)
flopy/utils/mtlistfile.py 89.9% <100.0%> (-0.1%) ⬇️
... and 3 more

@wpbonelli wpbonelli merged commit 8c3d7db into modflowpy:develop Aug 1, 2023
21 checks passed
@wpbonelli wpbonelli deleted the require-pandas branch August 1, 2023 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants