fix(binary): fix binary header information

[jdhughes-usgs]

No description provided.

[codecov]

Codecov Report

Merging #1848 (4ef943f) into develop (edb70b4) will increase coverage by 0.0%.
The diff coverage is 85.7%.

@@           Coverage Diff           @@
##           develop   #1848   +/-   ##
=======================================
  Coverage     72.3%   72.3%           
=======================================
  Files          255     255           
  Lines        56108   56122   +14     
=======================================
+ Hits         40573   40591   +18     
+ Misses       15535   15531    -4     

Impacted Files	Coverage Δ
flopy/utils/binaryfile.py	80.0% <ø> (ø)
flopy/utils/datafile.py	74.0% <ø> (ø)
flopy/mf6/data/mffileaccess.py	72.3% <85.7%> (+0.5%)	⬆️

... and 1 file with indirect coverage changes

[spaulins-usgs]

Looks good. My only concern is that you are changing some of the header variable names in datafile.py (ncol/nrow/ilay to m1/m2/m3) and that if a user was directly creating a binary header this change could break their code. However, I do not believe that users are creating their own MF6 binary file headers using flopy, so it might not be necessary to warn users of this interface change.

[jdhughes-usgs]

Looks good. My only concern is that you are changing some of the header variable names in datafile.py (ncol/nrow/ilay to m1/m2/m3) and that if a user was directly creating a binary header this change could break their code. However, I do not believe that users are creating their own MF6 binary file headers using flopy, so it might not be necessary to warn users of this interface change.

I agree this could create problems for people who might be using this directly. Hopefully know one is since the vardis, vardisv and vardisu methods are specific to MODFLOW 6 and really was not consistent with the mf6io document.