Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mf6): fix external binary files for vertex grids #1839

Merged

Conversation

jdhughes-usgs
Copy link
Contributor

Add tests for structured and vertex grid models with external binary files.

@codecov
Copy link

codecov bot commented Jun 25, 2023

Codecov Report

Merging #1839 (53d73b8) into develop (736c5b8) will increase coverage by 0.1%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop   #1839     +/-   ##
=========================================
+ Coverage     72.1%   72.3%   +0.1%     
=========================================
  Files          255     255             
  Lines        56108   56108             
=========================================
+ Hits         40499   40587     +88     
+ Misses       15609   15521     -88     
Impacted Files Coverage Δ
flopy/utils/datafile.py 74.0% <ø> (ø)
flopy/mf6/data/mffileaccess.py 72.3% <100.0%> (+7.7%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Contributor

@spaulins-usgs spaulins-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@jdhughes-usgs jdhughes-usgs merged commit 8113a88 into modflowpy:develop Jun 26, 2023
21 checks passed
@jdhughes-usgs jdhughes-usgs deleted the fix-binary-stress-package branch June 26, 2023 19:43
jdhughes-usgs added a commit to jdhughes-usgs/flopy that referenced this pull request Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants