Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(binaryfile): add reverse() methods #1829

Merged
merged 2 commits into from
Jul 29, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Jun 13, 2023

Add reverse() methods to CellBudgetFile and HeadFile, with corresponding tests. Originally planned as part of #1753 but expediting separately since this will be useful to develop PRT tests and example notebooks.

  • CellBudgetFile.reverse()
  • HeadFile.reverse()

To use either method, a tdis kwarg must have been provided in the binary file object constructor.

Also reorganize/expand some docstrings in binaryfile.py, add a get_nrecords() method to LayerFile, and split tests into test_cellbudgetfile.py and test_binaryfile.py

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Merging #1829 (6e41428) into develop (8c330a7) will increase coverage by 0.0%.
The diff coverage is 87.8%.

@@           Coverage Diff           @@
##           develop   #1829   +/-   ##
=======================================
  Coverage     72.2%   72.2%           
=======================================
  Files          257     257           
  Lines        56414   56508   +94     
=======================================
+ Hits         40751   40835   +84     
- Misses       15663   15673   +10     
Files Changed Coverage Δ
flopy/utils/datafile.py 74.3% <83.3%> (+0.2%) ⬆️
flopy/utils/binaryfile.py 80.8% <88.0%> (+0.7%) ⬆️

... and 2 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review July 28, 2023 18:39
@wpbonelli wpbonelli merged commit 7931112 into modflowpy:develop Jul 29, 2023
21 checks passed
@wpbonelli wpbonelli deleted the reverse-head-and-budget branch July 29, 2023 00:04
@wpbonelli wpbonelli mentioned this pull request May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant