Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(shapefile_utils): check attr.array for None in model_attributes_to_shapefile #1785

Merged
merged 1 commit into from
May 17, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented May 15, 2023

  • fix bug: shapefile_utils export fail with disu export #1775
  • if array data (e.g. angldegx) is missing, a warning is shown but export proceeds
  • add some test cases for above, factor out a function to create a sim with a GWF model on a DISU grid
  • update test_export.py::test_freyberg_export to check shapefiles exported for each level (model/pkg/obj) exist
  • update test_export.py::test_export_output to write netCDF files to tempdir instead of cwd

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #1785 (bc93381) into develop (badc431) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #1785   +/-   ##
=======================================
  Coverage     72.1%   72.1%           
=======================================
  Files          254     254           
  Lines        55929   55930    +1     
=======================================
+ Hits         40377   40380    +3     
+ Misses       15552   15550    -2     
Impacted Files Coverage Δ
flopy/export/shapefile_utils.py 87.8% <100.0%> (+<0.1%) ⬆️

... and 1 file with indirect coverage changes

@wpbonelli wpbonelli force-pushed the angldegx branch 2 times, most recently from 667795f to 4f9a850 Compare May 15, 2023 15:11
@wpbonelli wpbonelli marked this pull request as ready for review May 15, 2023 15:14
Copy link
Contributor

@langevin-usgs langevin-usgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, @w-bonelli. I say merge it in.

@wpbonelli wpbonelli merged commit 6569568 into modflowpy:develop May 17, 2023
@wpbonelli wpbonelli deleted the angldegx branch May 17, 2023 02:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: shapefile_utils export fail with disu export
2 participants