fix(mp6sim): use keyword args for pandas DataFrame.drop #1757
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1757 +/- ##
=========================================
- Coverage 72.1% 72.1% -0.1%
=========================================
Files 253 253
Lines 56100 56056 -44
=========================================
- Hits 40480 40436 -44
Misses 15620 15620
|
|
Merging despite failing CI to unblock other PRs. The Windows/Python3.11 failure is addressed in #1759 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pandas 2.0 made non-keyword arguments illegal for
DataFrame.drop(), update usage inmp6sim.py.