Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CellBudgetFile): strip auxname for imeth 5 #1716

Merged
merged 2 commits into from
Feb 13, 2023

Conversation

mwtoews
Copy link
Contributor

@mwtoews mwtoews commented Feb 13, 2023

There are two parts to this PR (each are both a commit):

  • A one-line fix (on L1781) to CellBudgetFile to strip spaces from auxname (e.g.) from "IFACE " to "IFACE". This was already considered for imeth 6 and most (all?) other 16-character strings from binary files.
  • Move tests related to binary files from test_formattedfile.py to test_binaryfile.py without any other changes, except for testing expected auxname values, which can be viewed in the other commit.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Merging #1716 (5a69906) into develop (2552de5) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #1716   +/-   ##
=======================================
  Coverage     71.9%   71.9%           
=======================================
  Files          253     253           
  Lines        55891   55891           
=======================================
+ Hits         40202   40212   +10     
+ Misses       15689   15679   -10     
Impacted Files Coverage Δ
flopy/utils/binaryfile.py 80.1% <100.0%> (ø)
flopy/utils/get_modflow.py 65.3% <0.0%> (+2.4%) ⬆️

@wpbonelli wpbonelli merged commit c2c44fe into modflowpy:develop Feb 13, 2023
@mwtoews mwtoews deleted the fix-budget-aux-name branch February 14, 2023 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants