Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package dictionary): removed package_key_dict since it is redundant and can cause errors #1690

Merged
merged 1 commit into from
Jan 26, 2023

Conversation

spaulins-usgs
Copy link
Contributor

package_key_dict has been removed and replaced with a property getter that gives a deprecation warning and returns the package_type_dict, which is functionally similar.

@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Merging #1690 (1d1fe8a) into develop (24448b7) will decrease coverage by 1.9%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop   #1690     +/-   ##
=========================================
- Coverage     71.8%   70.0%   -1.9%     
=========================================
  Files          253     253             
  Lines        55884   54524   -1360     
=========================================
- Hits         40177   38202   -1975     
- Misses       15707   16322    +615     
Impacted Files Coverage Δ
flopy/mf6/mfbase.py 73.2% <100.0%> (-8.0%) ⬇️
flopy/mf6/modflow/mfgwtgwt.py 33.3% <0.0%> (-29.8%) ⬇️
flopy/mf6/modflow/mfgwfcsub.py 39.0% <0.0%> (-28.2%) ⬇️
flopy/utils/compare.py 2.9% <0.0%> (-27.5%) ⬇️
flopy/mf6/modflow/mfgwtlkt.py 45.7% <0.0%> (-24.6%) ⬇️
flopy/mf6/modflow/mfgwtmwt.py 45.7% <0.0%> (-24.6%) ⬇️
flopy/mf6/modflow/mfgwtsft.py 45.7% <0.0%> (-24.6%) ⬇️
flopy/mf6/modflow/mfgwtuzt.py 45.7% <0.0%> (-24.6%) ⬇️
flopy/mf6/modflow/mfgwtcnc.py 46.1% <0.0%> (-23.5%) ⬇️
flopy/mf6/modflow/mfgwtsrc.py 46.1% <0.0%> (-23.5%) ⬇️
... and 88 more

@spaulins-usgs spaulins-usgs merged commit ebaef18 into modflowpy:develop Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant