fix(quotes+exe_path+nam_file): fixes for quoted strings, exe path, and nam file #1645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…iles with quoted strings. If all else fails trying to find exe_path, abs_path is used. Proper error message given when user attempts to create namefile.
Codecov Report
@@ Coverage Diff @@
## develop #1645 +/- ##
=======================================
Coverage 72.7% 72.7%
=======================================
Files 251 251
Lines 54504 54517 +13
=======================================
+ Hits 39671 39683 +12
- Misses 14833 14834 +1
|
jdhughes-usgs
approved these changes
Dec 8, 2022
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…d nam file (modflowpy#1645) * fix(quotes+exe_path+nam_file): Quotes properly removed when loading files with quoted strings. If all else fails trying to find exe_path, abs_path is used. Proper error message given when user attempts to create namefile. * test(quotes): added test for quoting of names in spaces Co-authored-by: jdhughes-usgs <jdhughes@usgs.gov>
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…d nam file (modflowpy#1645) * fix(quotes+exe_path+nam_file): Quotes properly removed when loading files with quoted strings. If all else fails trying to find exe_path, abs_path is used. Proper error message given when user attempts to create namefile. * test(quotes): added test for quoting of names in spaces Co-authored-by: jdhughes-usgs <jdhughes@usgs.gov>
wpbonelli
pushed a commit
that referenced
this pull request
Dec 14, 2022
…d nam file (#1645) * fix(quotes+exe_path+nam_file): Quotes properly removed when loading files with quoted strings. If all else fails trying to find exe_path, abs_path is used. Proper error message given when user attempts to create namefile. * test(quotes): added test for quoting of names in spaces Co-authored-by: jdhughes-usgs <jdhughes@usgs.gov>
wpbonelli
pushed a commit
to wpbonelli/flopy
that referenced
this pull request
Dec 14, 2022
…d nam file (modflowpy#1645) * fix(quotes+exe_path+nam_file): Quotes properly removed when loading files with quoted strings. If all else fails trying to find exe_path, abs_path is used. Proper error message given when user attempts to create namefile. * test(quotes): added test for quoting of names in spaces Co-authored-by: jdhughes-usgs <jdhughes@usgs.gov>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quotes properly removed when loading files with quoted strings (#1643). If all else fails trying to find exe_path, abs_path is used (#1633). Proper error message given when user attempts to create namefile (#1617).