Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contours): use standard contours for StructuredGrid map view plots #1615

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Nov 1, 2022

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1615 (1a574a1) into develop (5a9bec2) will decrease coverage by 0.0%.
The diff coverage is 64.5%.

@@            Coverage Diff            @@
##           develop   #1615     +/-   ##
=========================================
- Coverage     72.7%   72.7%   -0.1%     
=========================================
  Files          251     251             
  Lines        54501   54501             
=========================================
- Hits         39671   39651     -20     
- Misses       14830   14850     +20     
Impacted Files Coverage Δ
flopy/plot/map.py 82.3% <64.5%> (-1.9%) ⬇️
flopy/utils/get_modflow.py 64.0% <0.0%> (-1.5%) ⬇️
flopy/utils/geometry.py 74.5% <0.0%> (-1.3%) ⬇️
flopy/export/utils.py 65.4% <0.0%> (-0.3%) ⬇️

@wpbonelli wpbonelli marked this pull request as ready for review November 4, 2022 00:16
@mbakker7
Copy link
Contributor

I just tested this PR on my models that caused problems before and it works great.
It gets my approval if that is worth anything.
Can this PR be approved and merged (teaching a class in 2 weeks and would be great when there is a new flopy).

@jdhughes-usgs jdhughes-usgs merged commit 00757a4 into modflowpy:develop Nov 10, 2022
@wpbonelli wpbonelli deleted the plot-contours branch November 10, 2022 21:45
wpbonelli added a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
wpbonelli added a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
wpbonelli added a commit that referenced this pull request Dec 14, 2022
wpbonelli added a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants