-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(get_modflow): support modflow6 repo releases #1573
feat(get_modflow): support modflow6 repo releases #1573
Conversation
f758dc3
to
4a441ad
Compare
Codecov Report
@@ Coverage Diff @@
## develop #1573 +/- ##
=========================================
+ Coverage 72.5% 72.6% +0.1%
=========================================
Files 251 251
Lines 54293 54423 +130
=========================================
+ Hits 39377 39542 +165
+ Misses 14916 14881 -35
|
6d52ae8
to
e4cf9b9
Compare
b647fa0
to
d045f41
Compare
Or it can append new or modify existing entries in code.json. We probably need to harmonize the attributes/keys in the code.json files. |
d045f41
to
5c87f29
Compare
5c87f29
to
332141a
Compare
flopy/utils/get_modflow.py
Outdated
if ostag in asset["name"]: | ||
break | ||
|
||
# Windows asset in modflow6 repo release has no OS tag |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this can be removed later if future modflow6 releases use the same naming conventions for platform-specific zip files as the executables and nightly-build repos
mac.zip
linux.zip
win64.zip
* avoid div/0 with columns_str (with items longer than 79 chars) * change asset dst_fname for modflow6 * prevent "--repo modflow6 --ostag win32" from succeding
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've pushed a commit for a few changes. Roll back or comment anything that you disagree with. Here are my notes from my commit message:
- evaluate files to extract (rather than extracting to dowloads_dir)
- avoid div/0 with columns_str (with items longer than 79 chars)
- change asset dst_fname for modflow6
- prevent "--repo modflow6 --ostag win32" from succeding
@mwtoews thanks for the review and fixes My motivation for extracting the whole release instead of select files, besides not being sure which would be a less surprising option for the user, was because
|
* feat(get_modflow): support modflow6 repo releases * * evaluate files to extract (rather than extracting to dowloads_dir) * avoid div/0 with columns_str (with items longer than 79 chars) * change asset dst_fname for modflow6 * prevent "--repo modflow6 --ostag win32" from succeding Co-authored-by: Mike Taves <mwtoews@gmail.com>
* feat(get_modflow): support modflow6 repo releases * * evaluate files to extract (rather than extracting to dowloads_dir) * avoid div/0 with columns_str (with items longer than 79 chars) * change asset dst_fname for modflow6 * prevent "--repo modflow6 --ostag win32" from succeding Co-authored-by: Mike Taves <mwtoews@gmail.com>
* feat(get_modflow): support modflow6 repo releases * * evaluate files to extract (rather than extracting to dowloads_dir) * avoid div/0 with columns_str (with items longer than 79 chars) * change asset dst_fname for modflow6 * prevent "--repo modflow6 --ostag win32" from succeding Co-authored-by: Mike Taves <mwtoews@gmail.com>
* feat(get_modflow): support modflow6 repo releases * * evaluate files to extract (rather than extracting to dowloads_dir) * avoid div/0 with columns_str (with items longer than 79 chars) * change asset dst_fname for modflow6 * prevent "--repo modflow6 --ostag win32" from succeding Co-authored-by: Mike Taves <mwtoews@gmail.com>
Supports installing releases from the main modflow6 repository. Updates the
repo
option to acceptmodflow6
so the user can select any of the following:executables
(default)modflow6
modflow6-nightly-build
The
modflow6
repo's release archive contains most of the repository, not just binaries, so instead of unzipping directly tobindir
like the other 2 options, there is an extra step to unzip in the download location before copying binaries tobindir
.Adds a section describing repo selection to the docs. Also adds a table of contents.
Motivation
Besides covering the bases as far as distributions go, this is a step towards replacing the
pymake
dependency in modflow6 tests (currentlypymake
is used to download the latest mf6 release, among other things)