Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(obs): Modify observations to load single time step files #1559

Merged
merged 7 commits into from
Sep 29, 2022

Conversation

jdhughes-usgs
Copy link
Contributor

Return single time step observation files in the same form as multi-time step files
(disable default squeeze). Add test to evaluate this change.

@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #1559 (aff567e) into develop (14d69cb) will increase coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff           @@
##           develop   #1559   +/-   ##
=======================================
  Coverage     72.4%   72.4%           
=======================================
  Files          251     251           
  Lines        54216   54218    +2     
=======================================
+ Hits         39300   39302    +2     
  Misses       14916   14916           
Impacted Files Coverage Δ
flopy/utils/observationfile.py 88.3% <100.0%> (+<0.1%) ⬆️

Implementation that works for python versions less than 3.8
Implementation that works for python versions less than 3.8
autotest/test_obs.py Outdated Show resolved Hide resolved
Implementation that works for python versions less than 3.8.
Correct typo in new observation test.
@jdhughes-usgs jdhughes-usgs merged commit 06f08be into modflowpy:develop Sep 29, 2022
@jdhughes-usgs jdhughes-usgs deleted the fix-observation branch October 2, 2022 14:36
wpbonelli pushed a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
…py#1559)

Modify observations to load single time step files without default squeeze.
Implementation that works for python versions less than 3.8
wpbonelli pushed a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
…py#1559)

Modify observations to load single time step files without default squeeze.
Implementation that works for python versions less than 3.8
wpbonelli pushed a commit that referenced this pull request Dec 14, 2022
Modify observations to load single time step files without default squeeze.
Implementation that works for python versions less than 3.8
wpbonelli pushed a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
…py#1559)

Modify observations to load single time step files without default squeeze.
Implementation that works for python versions less than 3.8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants