Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aux variable checking): check now performs aux variable checking (#1399) #1536

Merged
merged 4 commits into from
Sep 12, 2022
Merged

Conversation

spaulins-usgs
Copy link
Contributor

Method "check" will not verify that aux variables are either numeric or part of a time series.

@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Merging #1536 (2c748b4) into develop (af42e78) will decrease coverage by 0.0%.
The diff coverage is 2.8%.

@@            Coverage Diff            @@
##           develop   #1536     +/-   ##
=========================================
- Coverage     72.5%   72.4%   -0.1%     
=========================================
  Files          251     251             
  Lines        54230   54299     +69     
=========================================
+ Hits         39326   39328      +2     
- Misses       14904   14971     +67     
Impacted Files Coverage Δ
flopy/mf6/mfpackage.py 64.2% <2.8%> (-3.2%) ⬇️

@spaulins-usgs spaulins-usgs merged commit c3cdc13 into modflowpy:develop Sep 12, 2022
wpbonelli pushed a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
…modflowpy#1399) (modflowpy#1536)

* feat(aux variable checking): check now performs aux variable checking (modflowpy#1399)

* feat(aux variable checking): test updates

* fix(aux validation): formatting
wpbonelli pushed a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
…modflowpy#1399) (modflowpy#1536)

* feat(aux variable checking): check now performs aux variable checking (modflowpy#1399)

* feat(aux variable checking): test updates

* fix(aux validation): formatting
wpbonelli pushed a commit that referenced this pull request Dec 14, 2022
…#1399) (#1536)

* feat(aux variable checking): check now performs aux variable checking (#1399)

* feat(aux variable checking): test updates

* fix(aux validation): formatting
wpbonelli pushed a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
…modflowpy#1399) (modflowpy#1536)

* feat(aux variable checking): check now performs aux variable checking (modflowpy#1399)

* feat(aux variable checking): test updates

* fix(aux validation): formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant