Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mfpackage): modify maxbound evaluation #1530

Merged
merged 2 commits into from
Sep 2, 2022

Conversation

jdhughes-usgs
Copy link
Contributor

Modified the way maxbound is evaluated relative to the size of the stress_period_data data. If maxbound is defined to be something other than None when a package is initialized the value is only modified if the sized of the stress_period_data exceeds the specified maxbound value. This change was precipitated by the need to set a maxbound value larger than the largest size of stress_period_data for use with the MODFLOW API.

This change also simplifies the three value boolean check that was used previously.

@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #1530 (534322a) into develop (f45c8f9) will decrease coverage by 1.3%.
The diff coverage is 100.0%.

@@            Coverage Diff            @@
##           develop   #1530     +/-   ##
=========================================
- Coverage     72.4%   71.1%   -1.4%     
=========================================
  Files          251     251             
  Lines        54163   52836   -1327     
=========================================
- Hits         39255   37580   -1675     
- Misses       14908   15256    +348     
Impacted Files Coverage Δ
flopy/mf6/mfpackage.py 63.3% <100.0%> (-4.0%) ⬇️
flopy/mf6/modflow/mfgwtgwt.py 33.3% <0.0%> (-29.8%) ⬇️
flopy/mf6/modflow/mfgwfcsub.py 39.0% <0.0%> (-28.2%) ⬇️
flopy/mf6/modflow/mfgwtlkt.py 45.7% <0.0%> (-24.6%) ⬇️
flopy/mf6/modflow/mfgwtmwt.py 45.7% <0.0%> (-24.6%) ⬇️
flopy/mf6/modflow/mfgwtsft.py 45.7% <0.0%> (-24.6%) ⬇️
flopy/mf6/modflow/mfgwtuzt.py 45.7% <0.0%> (-24.6%) ⬇️
flopy/mf6/modflow/mfgwtcnc.py 46.1% <0.0%> (-23.5%) ⬇️
flopy/mf6/modflow/mfgwtsrc.py 46.1% <0.0%> (-23.5%) ⬇️
flopy/mf6/modflow/mfgwfapi.py 47.3% <0.0%> (-22.4%) ⬇️
... and 87 more

@jdhughes-usgs
Copy link
Contributor Author

@spaulins-usgs could you take a look at this PR today. Some work I am doing with the MODFLOW API for the New York Water Science Center is dependent on this change. I ran all of the tests locally that are not run as part of the standard CI workflows and they passed.

@jdhughes-usgs jdhughes-usgs merged commit 265ee59 into modflowpy:develop Sep 2, 2022
@jdhughes-usgs jdhughes-usgs deleted the mf6-stressperioddata branch September 8, 2022 16:24
wpbonelli pushed a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
wpbonelli pushed a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
wpbonelli pushed a commit to wpbonelli/flopy that referenced this pull request Dec 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants