#2819 - this.skip() in before fails to skip tests with nested describe calls #2836
Conversation
this.skip() in before fails to skip tests with nested describe calls
|
Changes Unknown when pulling 5267c53 on Elergy:issue/2819 into ** on mochajs:master**. |
Elergy
changed the title
boneskull
added
the
status: needs review
|
Thank you, I didn't see #2571 before. |
| }); | ||
|
|
||
| it('should skip this test', function () { | ||
| expect(2).to.equal(1); |
There was a problem hiding this comment.
In all the failure cases, you should call fail directly: expect().to.fail('message here')
lib/runnable.js
Outdated
| * Mark the runnable as pending or not pending | ||
| * @param pending | ||
| */ | ||
| Runnable.prototype.setPending = function (pending) { |
There was a problem hiding this comment.
What is the value of switching from property to a method?
There was a problem hiding this comment.
In most cases, it's better to use setters instead of using properties directly.
It's a common problem with using properties (and I encountered this problem while fixing this bug) that it's not easy to understand where someone changes the property.
You know that the property was changed, but you don't know when - all you can do is to debug the whole application.
You can search for a string 'pending = ', but it can be a problem when several objects contain fields with the same name.
if you have a setter, you can easily set a breakpoint inside the setter and find who called this method very quickly.
boneskull
force-pushed
the
master
branch
2 times, most recently
from
4547268
to
7613521
Compare
this.skip() in before fails to skip tests with nested describe calls