Ouput test duration and stack trace in TAP YAML block #1209
Conversation
|
-1 from me, this is why TAP doesn't really make much sense, it's pretty useless on its own |
| */ | ||
| function writeDiagnostic(test, err){ | ||
| var obj = {}; | ||
| if (test.duration) obj.duration_ms = test.duration / 1000; |
There was a problem hiding this comment.
Wait, so the name suggest it's milliseconds (duration_ms) when in fact it is seconds (/ 1000)?!
There was a problem hiding this comment.
what? ms = seconds / 1000
A millisecond (from milli- and second; abbreviation: ms) is a thousandth (10−3 or 1/1,000) of a second.[1] Its symbol is ms. One millisecond is to one second as one second is to 16.67 minutes.
There was a problem hiding this comment.
Hmm, a couple of things went wrong here :) I assumed that test.duration was in milliseconds, since that's the standard unit in javascript.
Also, 1000ms === 1s so to convert from seconds to milliseconds we need to multiply it with 1000, since it takes 1000ms to make up 1s. Heh, converting between time units is always a pain.
The correct code should, I think, be obj.duration_ms = test.duration * 1000.
|
Unit fixed. Goes along with this pull request on the TAP plugin: jenkinsci/tap-plugin#6. |
|
Sorry, but afraid I agree with TJ. Although I appreciate the effort, I'm closing the PR. |
Compatible with https://wiki.jenkins-ci.org/display/JENKINS/TAP+Plugin