[style] break-word on screen max-width: 680px #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outsideris
reviewed
Aug 22, 2020
static/styles/jsdoc.css
Outdated
| @@ -661,6 +661,11 @@ html[data-search-mode] .level-hide { | |||
| margin: 1em 0; | |||
| } | |||
|
|
|||
| #main h4.name { | |||
| padding: .75em 10px .75em 10px; | |||
There was a problem hiding this comment.
Instead this, how about we put padding-right: 10px in global rule. I cannot see any reason we should put 0px for right padding in wide screen.
There was a problem hiding this comment.
Actually, I couldn't see any history too.
I fixed your feedback. I added padding-right: 10px in global rule and removed padding in media-query.
Thanks for your comment.
|
Thanks! This is probably fine, but we should probably configure netlify to build PRs here against the |
|
should rebase this onto |
|
OK, you can now see a preview of this change here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To fix #4412, I added word-break, padding of #main h4.name.
I think this is easy to read on mobile. It makes line breaks appear wherever the text would otherwise overflow like the examples below:
(The example width is 360px.)
AS-IS
TO-BE
