Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llb: deterministic marshaling for protobuf and store results from multiple constraints #5374

Merged
merged 1 commit into from
Oct 2, 2024

Commits on Oct 2, 2024

  1. llb: deterministic marshaling for protobuf and store results from mul…

    …tiple constraints
    
    This fixes a problem with the new protobuf marshaling with the standard
    library. LLB digests are now forced into deterministic marshaling to
    ensure they produce the same digest when marshaled multiple times.
    
    In addition, the marshal cache has also been fixed to work in
    multi-threaded frontends with multiple different constraints.
    Previously, if an LLB vertex was used in multiple goroutines and
    marshaled concurrently, the cache would be broken. This could cause
    certain problems when a specific node was used multiple times in the
    same LLB tree.
    
    Signed-off-by: Jonathan A. Sternberg <jonathan.sternberg@docker.com>
    jsternberg committed Oct 2, 2024
    Configuration menu
    Copy the full SHA
    d59218e View commit details
    Browse the repository at this point in the history