ci: update golangci-lint to v1.60.1 #5256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version runs out of memory on go1.23 Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
github-actions
bot
added
area/testing
area/hack
tonistiigi
commented
Aug 14, 2024
| @@ -37,10 +37,10 @@ func v0TarHeaderSelect(h *tar.Header) (orderedHeaders [][2]string) { | |||
|
|
|||
| func v1TarHeaderSelect(h *tar.Header) (orderedHeaders [][2]string) { | |||
| pax := h.PAXRecords | |||
| if len(h.Xattrs) > 0 { //nolint:staticcheck // field deprecated in stdlib | |||
| if len(h.Xattrs) > 0 { // field deprecated in stdlib | |||
There was a problem hiding this comment.
Don't really understand what changed here. All staticcheck rules should be enabled.
crazy-max
approved these changes
Aug 14, 2024
AkihiroSuda
approved these changes
Aug 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version runs out of memory on go1.23