readme: update instructions #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonistiigi
commented
Dec 21, 2017
| @@ -5,7 +5,6 @@ | |||
|
|
|||
| ## BuildKit | |||
|
|
|||
| <!-- godoc is mainly for LLB stuff --> | |||
There was a problem hiding this comment.
removed this because it shows up in https://hub.docker.com/r/tonistiigi/buildkit/
tonistiigi
force-pushed
the
update-readme
branch
from
8be3f83
to
3c9c7d0
Compare
AkihiroSuda
reviewed
Dec 21, 2017
README.md
Outdated
|
|
||
| ##### Building a Dockerfile using [external frontend](https://hub.docker.com/r/tonistiigi/dockerfile/tags/): | ||
|
|
||
| During development, an external version of the Dockerfile frontend us pushed to https://hub.docker.com/r/tonistiigi/dockerfile that can be used with the gateway frontend. The source for the external frontend is currently located in `./frontend/dockerfile/cmd/dockerfile-frontend` but will move out of this repository in the future (#163). |
There was a problem hiding this comment.
Could you set hyperlink?
AkihiroSuda
reviewed
Dec 21, 2017
README.md
Outdated
| buildctl build --frontend=dockerfile.v0 --local context=. --local dockerfile=. | ||
| buildctl build --frontend=dockerfile.v0 --local context=. --local dockerfile=. --frontend-opt target=foo --frontend-opt build-arg:foo=bar | ||
| ``` | ||
| go build -o /usr/local/bin/build-using-dockerfile ./examples/build-using-dockerfile |
There was a problem hiding this comment.
Typically this command should be executed as a non-privileged user.
go build ./examples/build-using-dockerfile && sudo install build-using-dockerfile /usr/local/bin ?
AkihiroSuda
reviewed
Dec 21, 2017
| We are open to adding more backends. | ||
|
|
||
| #### Exploring LLB | ||
|
|
There was a problem hiding this comment.
Can we have this image here, so that people can visually understand the concept of the graph?
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
update-readme
branch
from
3c9c7d0
to
a8e9c7e
Compare
|
Updated |
AkihiroSuda
approved these changes
Dec 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@AkihiroSuda
Signed-off-by: Tonis Tiigi tonistiigi@gmail.com