Fix MSTGQLStore.subscribe() when a DocumentNode is passed as query #396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: use Pinst to disable Husky in published NPM package * fix: ensure we always publish to the correct repository * chore: bump version, update CHANGELOG.md * fix: ignore peer dependencies when running Syncpack * refactor: move format check step to only run on CI * refactor: always format w/ `pretty-quick` for consistency * refactor: run Syncpack directly instead of using `yarn dlx` * chore: de-duplicate yarn.lock * chore: update yarn.lock with weird changes from tests * refactor: move CRA test into dedicated/isolated directory * refactor: remove cra-test from root worktree * ci: temporarily disable CRA test until we can improve it
query.toString() doesn't work here, because graphql doesn't implement it to convert the DocumentNode to a graphql string representation. Instead, print(query) has to be used.
|
Until this is merged the workaround is to use print() in your code when calling subscribe. eg: import { print } from 'graphql/language/printer'
gqlStore.subscribe(print(gql`...some graphql query`), ...) |
# Conflicts: # .gitignore # CHANGELOG.md # package.json # tests/cra-test/test-cra.sh # yarn.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The MSTGQLStore.subscribe() fails when a DocumentNode is passed as query, ie. when an object created using graphql-tag is passed.
The problem is that query.toString() doesn't work here, because graphql doesn't implement it
to convert the DocumentNode to a graphql string representation. Instead, print(query) has to be used.
mst-gql has no tests for subscriptions, but this fix can be tested in a project using mst-gql using
in package.json