Expose Clients for later initiation #303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is really great, I've also had problems reconfiguring clients - especially the WS client - when authentication changes. @chrisdrackett can you please take a look at this? |
|
Looks good, thanks a lot @BradenM |
jesse-savary
pushed a commit
that referenced
this pull request
Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes
gqlHttpClientandgqlWsClientby moving them toMSTGQLStore's volatile state and providing setter actions.This is so either client can be initiated / changed at a later time instead of being de-referenced from the mst env.
Personally needed this because my env had an initial state that defined
gqlWsClientas null and later initiated it when it could be provided with an authentication token. But, since the current behavior de-references the clients, reassigning it from my env would not propagate to mst-gql and it would throw an error.