Skip to content
This repository has been archived by the owner on Dec 31, 2020. It is now read-only.

Updating to React 16.8.0-alpha.1 #54

Closed
wants to merge 2 commits into from
Closed

Updating to React 16.8.0-alpha.1 #54

wants to merge 2 commits into from

Conversation

DimitarNestorov
Copy link

@DimitarNestorov DimitarNestorov commented Feb 1, 2019 •
edited
Loading

useImperativeMethods was renamed to useImperativeHandle

@coveralls
Copy link

coveralls commented Feb 1, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 066f481 on dimitarnestorov:master into 7c529b3 on mobxjs:master.

@alsotang
Copy link
Contributor

alsotang commented Feb 2, 2019

LGTM. But lockfile is complex and vulnerable for hacker, so we should generate it ourselves.

@danielkcz
Copy link
Collaborator

I think I would rather rewrite that test. It's unnecesary to use that in there. I don't want to update those dependencies at all. I am sure there are still some projects (including mine) that are running early 16.7 alpha.

@danielkcz
Copy link
Collaborator

danielkcz commented Feb 6, 2019 •
edited
Loading

Closing in favor of #57, thanks for contribution.

@danielkcz danielkcz closed this Feb 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DimitarNestorov @coveralls @alsotang @danielkcz