-
Notifications
You must be signed in to change notification settings - Fork 306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attributes with 'v2x' are serialized as 'V2x', but should be serialized as 'V2X' #522
Attributes with 'v2x' are serialized as 'V2x', but should be serialized as 'V2X' #522
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you have an example of string that's mutated incorrectly?
This is the example you gave in #431 |
Can you add a test to cover the change? |
Lol, I must have forgotten this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The handling of V2X
is ok, but to avoid confusion I would handle SoC
at the start of a word in the same way (which is not the point of THIS PR).
…2x',-but-should-be-serialized-as-'V2X'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.