Handle responder_url edge case #336
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
@Jared-Newell-Mobility This one is also required for a v1 release. You can take it over the issue and finish it. |
|
Thanks for highlighting this, it has been replaced with PR #592, so it will close for now |
Merged
Jared-Newell-Mobility
added a commit
that referenced
this pull request
Feb 14, 2024
## 1.0.0-rc.1 (2024-02-14) - [#573](#573) Introduce Experimental Module For v2.1 - [#547](#547) Feat: Handle recursively serializing a dataclasses as a dictionary Thanks [@MacDue](https://github.com/MacDue) - [#601](#601) Fix case conversion for soc in non "State of Charge" context - [#523](#523) The serialisation of soc to SoC should not occur in camel case if it is existing at the beginning of a field - [#515](#515) Update Readthedocs configuration - [#602](#602) Correct v2g serialisation/deserialisation - [#557](#557) OCPP 2.0.1 Wrong data type in CostUpdated total_cost - [#564](#564) Add support For Python 3.11 and 3.12 - [#583](#583) OCPP v1.6/v2.0.1 deprecate dataclasses from calls and call results with the suffix 'Payload' - [#590](#336) snake_to_camel_case url to URL does not get converted correctly - [#591](#591) Camel_to_snake_case doesn't handle v2x correctly - [#593](#593) Update tests to use Call and CallResult without the suffix Payload - [#435](#435) Typo in CostUpdated Action - [#577](#577) v2.0.1 AttributeType Enum Corrections - [#340](#340) 2.0.1 dataclasses have a incorrect types that don't match carnality - [#519](#519) Typo in v201.enums.StatusInfoReasonType.invaild_schedule - [#510](#510) v2.0.1 UnitOfMeasureType - Enums missing and update docstring to allow use for variableCharacteristics - [#508](#508) Exception - OccurrenceConstraintViolationError doc string correction ## DEPRECATED ## - [#599](#599) v1.6 Action Enum members corrected IMPORTANT SEE UPGRADE PATH [#599](#599) - [#579](#579) v2.0.1 Action enums corrected - IMPORTANT SEE UPGRADE PATH [#579](#579) ## BREAKING ## - [#574](#574) Remove v1.6 deprecated enum members - IMPORTANT see upgrade path [#574](#574) - [#498](#498) Remove support for OCPP 2.0 - IMPORTANT SEE UPGRADE PATH [#498](#498)
RoaringDev1203
added a commit
to RoaringDev1203/Cratus-OCPP
that referenced
this pull request
Aug 27, 2024
## 1.0.0-rc.1 (2024-02-14) - [#573](mobilityhouse/ocpp#573) Introduce Experimental Module For v2.1 - [#547](mobilityhouse/ocpp#547) Feat: Handle recursively serializing a dataclasses as a dictionary Thanks [@MacDue](https://github.com/MacDue) - [#601](mobilityhouse/ocpp#601) Fix case conversion for soc in non "State of Charge" context - [#523](mobilityhouse/ocpp#523) The serialisation of soc to SoC should not occur in camel case if it is existing at the beginning of a field - [#515](mobilityhouse/ocpp#515) Update Readthedocs configuration - [#602](mobilityhouse/ocpp#602) Correct v2g serialisation/deserialisation - [#557](mobilityhouse/ocpp#557) OCPP 2.0.1 Wrong data type in CostUpdated total_cost - [#564](mobilityhouse/ocpp#564) Add support For Python 3.11 and 3.12 - [#583](mobilityhouse/ocpp#583) OCPP v1.6/v2.0.1 deprecate dataclasses from calls and call results with the suffix 'Payload' - [#590](mobilityhouse/ocpp#336) snake_to_camel_case url to URL does not get converted correctly - [#591](mobilityhouse/ocpp#591) Camel_to_snake_case doesn't handle v2x correctly - [#593](mobilityhouse/ocpp#593) Update tests to use Call and CallResult without the suffix Payload - [#435](mobilityhouse/ocpp#435) Typo in CostUpdated Action - [#577](mobilityhouse/ocpp#577) v2.0.1 AttributeType Enum Corrections - [#340](mobilityhouse/ocpp#340) 2.0.1 dataclasses have a incorrect types that don't match carnality - [#519](mobilityhouse/ocpp#519) Typo in v201.enums.StatusInfoReasonType.invaild_schedule - [#510](mobilityhouse/ocpp#510) v2.0.1 UnitOfMeasureType - Enums missing and update docstring to allow use for variableCharacteristics - [#508](mobilityhouse/ocpp#508) Exception - OccurrenceConstraintViolationError doc string correction ## DEPRECATED ## - [#599](mobilityhouse/ocpp#599) v1.6 Action Enum members corrected IMPORTANT SEE UPGRADE PATH [#599](mobilityhouse/ocpp#599) - [#579](mobilityhouse/ocpp#579) v2.0.1 Action enums corrected - IMPORTANT SEE UPGRADE PATH [#579](mobilityhouse/ocpp#579) ## BREAKING ## - [#574](mobilityhouse/ocpp#574) Remove v1.6 deprecated enum members - IMPORTANT see upgrade path [#574](mobilityhouse/ocpp#574) - [#498](mobilityhouse/ocpp#498) Remove support for OCPP 2.0 - IMPORTANT SEE UPGRADE PATH [#498](mobilityhouse/ocpp#498)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the 2.0.1 spec for
AuthorizeRequestandGetCertificateStatusRequestthere is a field responderURL that does not get converted from snake_caseresponder_urlto camelCaseresponderURL. This PR adds handling of this edge case. inSetNetworkProfileRequestthere is a fieldocppCsmsUrlwhich is handled correctly but causes problems for a more general solution.Let me know if the conditionals work for you.