Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: AndroidTV-Remote navigation #148

Merged
merged 7 commits into from
Sep 9, 2022
Merged

feature: AndroidTV-Remote navigation #148

merged 7 commits into from
Sep 9, 2022

Conversation

depapp
Copy link
Contributor

@depapp depapp commented Sep 9, 2022

hi all,

I've added AndroidTV Remote navigation to pressKey()

  • Remote Dpad Up
  • Remote Dpad Down
  • Remote Dpad Left
  • Remote Dpad Right
  • Remote Dpad Center
  • Remote Media Play Pause
  • Remote Media Stop
  • Remote Media Next
  • Remote Media Previous
  • Remote Media Rewind
  • Remote Media Fast Forward

please let me know if I miss anything 🙇🏻

Copy link
Contributor

@dmitry-zaitsev dmitry-zaitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the submission - you are almost there, just need to update the test

@depapp
Copy link
Contributor Author

depapp commented Sep 9, 2022

Thank you for the submission - you are almost there, just need to update the test

hi @dmitry-zaitsev

thanks for the review, I've updated on ac69848

please let me know if I miss anything 🙇🏻

Copy link
Contributor

@dmitry-zaitsev dmitry-zaitsev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for the contribution

@dmitry-zaitsev dmitry-zaitsev merged commit bc9e382 into mobile-dev-inc:main Sep 9, 2022
@depapp depapp deleted the feature/pressKeyRemote branch September 9, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants