Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build on nightly rustc #1

Closed
wants to merge 1 commit into from
Closed

Fix build on nightly rustc #1

wants to merge 1 commit into from

Conversation

petrochenkov
Copy link

Hi.
rust-lang/rust#42136 is going to turn some old compatibility warnings in rustc into hard errors.
crates.io testing discovered that this crate is affected by one of those errors (default type parameters on impls).
This PR updates the code to build successfully with rust-lang/rust#42136

bors added a commit to rust-lang/rust that referenced this pull request Jun 1, 2017
Turn sufficiently old compatibility lints into hard errors

It's been almost 7 months since #36894 was merged, so it's time to take the next step.

[breaking-change], needs crater run.

PRs/issues submitted to affected crates:
https://github.com/alexcrichton/ctest/pull/17
Sean1708/rusty-cheddar#55
m-r-r/helianto#3
azdle/virgil#1
rust-locale/rust-locale#24
mneumann/acyclic-network-rs#1
reem/rust-typemap#38

cc https://internals.rust-lang.org/t/moving-forward-on-forward-compatibility-lints/4204
cc #34537 #36887
Closes #36886
Closes #36888
Closes #36890
Closes #36891
Closes #36892
r? @nikomatsakis
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Jun 1, 2017
@petrochenkov
Copy link
Author

@mneumann
Closing due to inactivity.
The crate still doesn't build on nightly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant