Fix #144 (no comm. on 1st class Sunday) #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmolenda
requested changes
Jul 6, 2023
| # The feast of the Immaculate Conception of the Blessed Virgin Mary, however, | ||
| # is preferred to the Sunday of Advent on which it may occur. (General Rubrics, 15) | ||
| if date_ == date(date_.year, 12, 8) and date_.weekday() == SUNDAY: | ||
| return [match(observances, PATTERN_SANCTI)], [match(observances, PATTERN_TEMPORA)], [] |
There was a problem hiding this comment.
There are already some tests covering the cases like the Sunday on December 8, Sunday on another day, December 8 not on Sunday.
test_given_date_contains_proper_day_ids:
((1907, 12, 8), [c.TEMPORA_ADV2_0], [c.SANCTI_12_08], [c.TEMPORA_ADV2_0]),
((1912, 12, 8), [c.TEMPORA_ADV2_0], [c.SANCTI_12_08], [c.TEMPORA_ADV2_0]),
((1913, 12, 8), [c.TEMPORA_ADV2_1], [c.SANCTI_12_08], []),
test_conflicts:
((2019, 12, 8), [c.SANCTI_12_08], [c.TEMPORA_ADV2_0]),
((2019, 9, 8), [c.TEMPORA_PENT13_0], [c.SANCTI_09_08]),
(the second one is a Sunday not on December 8, which proves that the new code didn't force a commemoration of the Sunday)
test_calculated_commemorations:
# In Conceptione Immaculata Beatæ Mariæ Virginis, commemoration of the Sunday
((2019, 12, 8), …
Is something missing? By the way this is how I discovered the problem after fixing the original issue. These tests were failing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.