Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open Graph Image Tag for Header Overlay Images #358

Merged
merged 1 commit into from Jun 13, 2016
Merged

Open Graph Image Tag for Header Overlay Images #358

merged 1 commit into from Jun 13, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jun 12, 2016

Add Open Graph Image tag if page.header.overlay_image is used. Additionally, fix a casing issue in the theme's generated microdata.

@ghost ghost changed the title Use header overlay images for Open Graph image Open Graph Image Tag for Header Overlay Images Jun 13, 2016
@@ -113,7 +115,7 @@
<script type="application/ld+json">
{
"@context" : "http://schema.org",
"@type" : "{% if site.social.type %}{{ site.social.type }}{% else %}person{% endif %}",
"@type" : "{% if site.social.type %}{{ site.social.type }}{% else %}Person{% endif %}",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually per the schema spec I believe this is suppose to be capitalized.

jekyll-seo-tag suggests the capitalized version as well.

type - The type of things that the page represents. This must be a Schema.org type, and will probably usually be something like BlogPosting, NewsArticle, Person, Organization, etc.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the background. I noticed it should be capitalized it after seeing feedback from https://webmaster.yandex.com/microtest.xml.

@ghost
Copy link
Author

ghost commented Jun 13, 2016

Made a small update to change http to :// to match recent changes and updated with master. Confirmed overlay images are now pulling through to share widget as pictured below:

screen shot 2016-06-13 at 11 16 36 am

@mmistakes mmistakes merged commit beaaa88 into mmistakes:master Jun 13, 2016
@mmistakes
Copy link
Owner

Thanks sir.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant