iOS navigation with one tap closes #315 #330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
mentioned this pull request
| } |
There was a problem hiding this comment.
Just saw insert_final_newline = false in your .editorconfig file and had to do a double take on my editor. But EditorConfig is enabled. YOLO
|
I think there's a way to do this and preserve the hover effect... Even on touch enabled devices. On my personal site mademistakes.com I do pretty much the same effect on the main navigation links and there's no double tap on iOS. Just need to adjust the CSS some to match. |
|
Look at that. And it works on WebKit Mobile. Sweet. Will close this for now since we know there are other ways to resolve |
ghost
closed this
cjmadsen
pushed a commit
to cjmadsen/cjmadsen.github.io
that referenced
this pull request
Dec 7, 2016
Rename an existing theme
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
does what is says on the box. tested on iPhone 6 via
ngrokafter runningnpm run build:css.