Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump ForwardDiff upper bound #47

Merged
merged 1 commit into from
Dec 15, 2017
Merged

bump ForwardDiff upper bound #47

merged 1 commit into from
Dec 15, 2017

Conversation

mlubin
Copy link
Owner

@mlubin mlubin commented Nov 25, 2017

From what I can tell, no changes are needed here for ForwardDiff 0.7.
@jrevels, could you confirm?

@mlubin
Copy link
Owner Author

mlubin commented Dec 15, 2017

Ping @jrevels

@jrevels
Copy link
Collaborator

jrevels commented Dec 15, 2017

Hmm. Depends on if you need nested Duals to work. IIUC, the recent changes to the tagging mechanism mean that you can't easily hand-roll a tag anymore, because there's now a tag promotion mechanism that can get invoked in computations with nested Duals.

Sorry for the late response! This PR must've slipped by somehow...

@mlubin
Copy link
Owner Author

mlubin commented Dec 15, 2017

There's no use of nested duals here. Thanks!

@mlubin mlubin merged commit 1bd8760 into master Dec 15, 2017
@mlubin mlubin deleted the ml/fd branch December 15, 2017 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mlubin @jrevels