Skip to content

Commit

Permalink
fix: removed pkce code challange check for WebUI (argoproj#16730)
Browse files Browse the repository at this point in the history
Signed-off-by: Patrick Kerwood <patrick@kerwood.dk>
  • Loading branch information
Kerwood authored and mkieweg committed Jun 11, 2024
1 parent 4cd2327 commit 370c26c
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions ui/src/app/login/components/utils.ts
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,6 @@ export const pkceLogin = async (oidcConfig: AuthSettings['oidcConfig'], redirect
throw new PKCELoginError('No Authorization Server endpoint found');
}

if (!authorizationServer?.code_challenge_methods_supported?.includes('S256')) {
throw new PKCELoginError('Authorization Server does not support S256 code challenge method');
}

const codeVerifier = generateRandomCodeVerifier();

const codeChallange = await calculatePKCECodeChallenge(codeVerifier);
Expand Down

0 comments on commit 370c26c

Please sign in to comment.