-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MIKMIDISequencer stops recording almost immediately after starting if its sequence is empty. #45
Comments
It also plays a single piano note when you start recording. I haven't investigated at all, but perhaps that's a pre-roll problem? |
I pushed a fix for this. I'll let you close this if you think the fix looks OK. It's simple enough that I worry I overlooked something. I made a new issue #46 for the piano note at the beginning problem. |
We discussed adding a property to make this configurable. The thinking is that some apps may want recording a new track in an existing sequence to stop when the end of the sequence (ie. longest track) is reached. The default for this property would be NO (ie. doesn't stop). I think we should also extend the length of an empty sequence to something reasonable. |
I hit into an issue related to this change today:
During recording, the sequencer continues processing without stopping when it hits the end of its sequence's length. The issue is that if there's a note right on the timestamp for the end of the sequence (16 in this case) it is repeatedly scheduled every time through the processing loop. |
…s last note in a sequence while recording.
…ngAtEndOfSequence to MIKMIDISequencer.
Closing because I can no longer reproduce this. I believe it was fixed by |
See the MIDI Files Testbed project in the 1.1 branch to reproduce this. Maybe I've screwed something up...
The text was updated successfully, but these errors were encountered: