-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Umar/5124 create external resource with add links #2279
base: master
Are you sure you want to change the base?
Umar/5124 create external resource with add links #2279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
Is this behind a (posthog) feature flag? I want to be able to control the roll-out of this feature, limiting it to certain users until it's been thoroughly tested. |
Is this blocked by #2291 ? |
Yes. It was. But I can rebase on the branch and work on it now, since PostHog has been integrated with core functionality. Additional changes for PostHog integration will be done later in separate tickets. |
…s to get_or_create resources
… for linkUI when ER is created
0500832
to
2c53647
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Holding this since adding a link without selection ends up with both of |
When fixing #2279 (comment) be sure to add a test Otherwise this should get merged Thursday 9/26 |
What are the relevant tickets?
Closes https://github.com/mitodl/hq/issues/5124
Description (What does it do?)
This change is aimed to add External Resources on Link Add/Update. The syntax used for Link will be replaced with syntax for Resources in Markdown i.e.
{{ % resource_link "uuid" "title" % }}
How can this be tested?
umar/5124-create-external-resource-with-add-links
branch inocw-studio
Additional Testing
Enable/disable
OCW_STUDIO_CUSTOM_LINKUI_ENABLE
feature flag on PostHog to enable/disable the feature for users.Setup PostHog with instruction in the Readme.