Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): ページキャッシュ機能を一時的に無効化 #14296

Closed

Conversation

kakkokari-gtyih
Copy link
Contributor

What

RouterViewのKeepAliveを一時的に除去

Why

#14170 対策

Additional info (optional)

Checklist

  • Read the contribution guide
  • Test working in a local environment
  • (If needed) Add story of storybook
  • (If needed) Update CHANGELOG.md
  • (If possible) Add tests

@github-actions github-actions bot added the packages/frontend Client side specific issue/PR label Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 20.30%. Comparing base (32651ab) to head (66e2812).

Files Patch % Lines
packages/frontend/src/pages/settings/general.vue 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##           develop   #14296       +/-   ##
============================================
- Coverage    40.08%   20.30%   -19.78%     
============================================
  Files         1524      702      -822     
  Lines       188758    98737    -90021     
  Branches      3465     1029     -2436     
============================================
- Hits         75656    20052    -55604     
+ Misses      112528    78162    -34366     
+ Partials       574      523       -51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kakkokari-gtyih kakkokari-gtyih marked this pull request as ready for review July 24, 2024 11:03
@kakkokari-gtyih
Copy link
Contributor Author

vuejs/core#11431 入りのリリースがv2024.7.0に間に合う可能性があるのでこれマージしなくていい説がある

@syuilo
Copy link
Member

syuilo commented Jul 25, 2024

#14170 ってそんなにクリティカル?

@kakkokari-gtyih
Copy link
Contributor Author

kakkokari-gtyih commented Jul 25, 2024

#14170 ってそんなにクリティカル?

たぶんページコンポーネントのローディング中に別のページに遷移したらバグるので、低スペックだったり回線が遅かったりすると発生しやすいことを考えると、わりとUXに影響しそう
(ただしvue側の修正がそのうち入りそうなのでべつにこのPRで対処する必要はない気がしている)

@syuilo
Copy link
Member

syuilo commented Jul 25, 2024

まだ vuejs/core#11427 がバグ認定されてないことを考えるとまだ先じゃないかしら

@syuilo
Copy link
Member

syuilo commented Jul 25, 2024

Vueのバージョン戻すとか

@kakkokari-gtyih
Copy link
Contributor Author

Vueのバージョン戻すとか

戻すにしてもどこまで戻せば再現しないのかが分からないのよね

@kakkokari-gtyih
Copy link
Contributor Author

まだ vuejs/core#11427 がバグ認定されてないことを考えるとまだ先じゃないかしら

Update: バグ認定された

@kakkokari-gtyih
Copy link
Contributor Author

近日中に修正される可能性が高くなったためclose

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
packages/frontend Client side specific issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants