Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The map has odd behavior if Map.drawFreehand is called during a Map.editFeature #45

Closed
sjpinizzotto opened this issue Feb 3, 2017 · 6 comments

Comments

@sjpinizzotto
Copy link

Each map instance maintains a state: "ready", "edit", "draw" etc. Add a new state for "freehand".

When map enters into freehand mode, it is incompatible with the draw or edit mode. It should check prior to entering into that mode to see if it should cancel the draw or edit transaction.

Similarly if you are in edit or draw modes, and try to go into freehand mode, it should prompt if you should finish the draw or edit transaction, otherwise cancel out of the freehand draw.

@alberto-acevedo
Copy link
Contributor

new state of freehand was already in the core. Now asking the user about continuing with new freehand operation while cancelling any current draw/edit operation, and vice versa.

Use branch #45

Plot a path. Edit path. while in edit mode go to freehand mode. The test is a success if a confirmation is shown to the user asking about proceeding with the freehand mode and cancelling the edit operation.

Draw a path. While in draw mode go to freehand mode. The test is a success if a confirmation is shown to the user asking about proceeding with the freehand mode and cancelling the draw operation.

Start freehand mode. While in freehand mode edit a feature. The test is a success if a confirmation is shown to the user asking about proceeding with the edit mode and cancelling the freehand operation.

Start freehand mode. While in freehand mode draw a feature. The test is a success if a confirmation is shown to the user asking about proceeding with the draw mode and cancelling the freehand operation.

@mubinakhan
Copy link

verify

@mubinakhan
Copy link

issue#45.PNG

@alberto-acevedo
Copy link
Contributor

Working as expected, I don't see anything wrong in the snapshot.

@mubinakhan
Copy link

Reintegrate

@alberto-acevedo
Copy link
Contributor

Merged into the development branch. Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants