Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MapService setVisible() and remove() do not work. #347

Closed
georgegtx opened this issue Jul 26, 2017 · 1 comment
Closed

MapService setVisible() and remove() do not work. #347

georgegtx opened this issue Jul 26, 2017 · 1 comment
Assignees
Milestone

Comments

@georgegtx
Copy link

These methods check for a property "id" instead of "geoId" and fail stating: "This layer does not have an ID. Has it been added to the map yet?".

setVisible will also fail after some lines when trying to set "this.properties.visible" because "this.properties" is undefined.

And again after some lines when constructing the command to send to the MessageHander it uses
"emp3.api.channels.showFeature" and "emp3.api.channels.hideFeature" and "emp3.api.chanels.unplotFeature" instead of
"emp3.api.enums.channel.showFeature" and "emp3.api.enums.channel.hideFeature" and "emp3.api.enums.channel.unplotFeature".

@georgegtx georgegtx changed the title MapService setVisible and remove() do not work. MapService setVisible() and remove() do not work. Jul 26, 2017
georgegtx added a commit to georgegtx/emp3-web that referenced this issue Jul 26, 2017
@alberto-acevedo
Copy link
Contributor

George -Your fix will be part of emp3-web version 2.10.0 that is going soon.

There is another way to remove the service by using the emp3.api.Map.removeMapService(args); This is the way the API tester is using.

Thank you for submitting the fixes.

alberto-acevedo added a commit that referenced this issue Jul 28, 2017
…ng property assigment in mapService class. Also fixes trying to access non existing properties property. #347
@alberto-acevedo alberto-acevedo added this to the Sprint 2.10.0 milestone Jul 28, 2017
georgegtx added a commit to georgegtx/emp3-web that referenced this issue Aug 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants