entropy adjustments: check return value of rdrand/rdseed (and retry up to 10 times), cope with AMD ryzen 3000 bug #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
https://software.intel.com/en-us/articles/intel-digital-random-number-generator-drng-software-implementation-guide detect and disable bad rdrand on AMD ryzen 3000, which returns all-ones https://arstechnica.com/gadgets/2019/10/how-a-months-old-amd-microcode-bug-destroyed-my-weekend/
hannesm
force-pushed
the
entropy-fixes
branch
from
72439a5
to
cfb1839
Compare
cfcs
requested changes
Feb 26, 2020
…accumulating random bootstrap: use (checked!) rdrand/rdseed multiple times, if not available use whirlwind thrice
cfcs
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check rdrand and rdseed return values (CR=1), as recommended by Intel (https://software.intel.com/en-us/articles/intel-digital-random-number-generator-drng-software-implementation-guide)
detect bad rdrand on ryzen 3000 (which returns all-ones) and disable there