Design System smoke tests #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is being brought from [C100 application](https://github.com/ministryofjustice/c100-application) so that we can test the markup generated by the Design System gem.
Creates two fixtures one for the form and another for the errors on the form. Compares the current markup with the fixtures.
zheileman
approved these changes
Nov 12, 2020
features/step_definitions/common.rb
Outdated
| @@ -61,8 +60,7 @@ | |||
| end | |||
|
|
|||
| When(/^I am completing a basic 18 or over "([^"]*)" conviction$/) do |value| | |||
| step %[I visit "/"] | |||
| step %[I click the "Start now" link] | |||
| step %[I have started an application] | |||
There was a problem hiding this comment.
Super minor thing, but maybe instead of an application this might be a a check, for this service?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During an upgrade to the Design System on C100 it was noticed that the forms were not working properly with hints on check boxes (x-govuk/govuk-form-builder#211).
We decided to introduce the same mechanism used on C100 in Disclosure Checker.
Story: https://mojdigital.teamwork.com/#/tasks/22441209