Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "warp-client-file" hosts file #297

Closed
wants to merge 1 commit into from

Conversation

harshavardhana
Copy link
Member

No description provided.

klauspost added a commit to klauspost/warp that referenced this pull request Jan 26, 2024
Allow file as host input for benchmark targets or clients.

Example `warp-hosts.txt`:

```
127.0.0.1:{9001...9004}

127.1.2.3
giga.abc.com
```

Debug printing loaded hosts:
```
λ warp stat --host=file:warp-hosts.txt
HOSTS: [127.0.0.1:9001 127.0.0.1:9002 127.0.0.1:9003 127.0.0.1:9004 127.1.2.3 giga.abc.com]

λ warp stat --warp-client=file:warp-hosts.txt
hosts [127.0.0.1:9001 127.0.0.1:9002 127.0.0.1:9003 127.0.0.1:9004 127.1.2.3 giga.abc.com]
```

Slightly more generic version of minio#297 (and avoids another flag)
@klauspost klauspost mentioned this pull request Jan 26, 2024
klauspost added a commit that referenced this pull request Jan 28, 2024
* Add host file input

Allow file as host input for benchmark targets or clients.

Example `warp-hosts.txt`:

```
127.0.0.1:{9001...9004}

127.1.2.3
giga.abc.com
```

Debug printing loaded hosts:
```
λ warp stat --host=file:warp-hosts.txt
HOSTS: [127.0.0.1:9001 127.0.0.1:9002 127.0.0.1:9003 127.0.0.1:9004 127.1.2.3 giga.abc.com]

λ warp stat --warp-client=file:warp-hosts.txt
hosts [127.0.0.1:9001 127.0.0.1:9002 127.0.0.1:9003 127.0.0.1:9004 127.1.2.3 giga.abc.com]
```

Slightly more generic version of #297 (and avoids another flag)
@klauspost klauspost closed this Jan 28, 2024
@harshavardhana harshavardhana deleted the warp-bench branch January 28, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants