Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ampersand in sheet names #574

Merged
merged 3 commits into from
Mar 24, 2024
Merged

Allow ampersand in sheet names #574

merged 3 commits into from
Mar 24, 2024

Conversation

ofthelit
Copy link
Contributor

This pull request addresses three issues:

  • It enables the creation of an Excel file with an ampersand in the sheet names by encoding '&' as & when writing the XML.
  • The unit tests are now functional in environments where the default culture uses a comma as the default decimal separator.
  • The column width now consistently uses a dot when serializing the width double.

@shps951023 shps951023 merged commit 567d70b into mini-software:master Mar 24, 2024
2 checks passed
@shps951023
Copy link
Member

@ofthelit ❤❤❤ Could I invite you to our team?

@ofthelit ofthelit deleted the ampersand-in-sheet-name branch March 25, 2024 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shps951023 shps951023 shps951023 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ofthelit @shps951023