Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed semiauto derivation of Default instances #764

Merged
merged 1 commit into from
Sep 12, 2017

Conversation

joroKr21
Copy link
Collaborator

Achieved via refactoring of DefaultMacros.materialize.

Fixes #747

Achieved via refactoring of `DefaultMacros.materialize`.
@joroKr21
Copy link
Collaborator Author

Some missing functionality in Scala 2.10 makes things more verbose. Depending on how #655 turns out, DefaultMacros can be simplified at a later point (probably true for other macros as well).

@codecov-io
Copy link

Codecov Report

Merging #764 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #764   +/-   ##
=======================================
  Coverage   86.96%   86.96%           
=======================================
  Files          90       90           
  Lines        2517     2517           
  Branches       53       53           
=======================================
  Hits         2189     2189           
  Misses        328      328
Impacted Files Coverage Δ
core/src/main/scala/shapeless/default.scala 0% <ø> (ø) ⬆️
core/src/test/scala/shapeless/default.scala 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c18ae8d...71e97ed. Read the comment docs.

@milessabin
Copy link
Owner

LGTM! Many thanks ... merging :-)

@milessabin milessabin merged commit 9a66fae into milessabin:master Sep 12, 2017
@joroKr21 joroKr21 deleted the default-macros branch September 14, 2017 03:53
@milessabin
Copy link
Owner

Although Travis showed this as green previously, rerunning the build after clearing the build caches results in a build failure on 2.10.x: https://travis-ci.org/milessabin/shapeless/builds/274500921.

Would you mind taking a look?

@joroKr21
Copy link
Collaborator Author

joroKr21 commented Sep 29, 2017

This looks like a spurious error. I saw it in #765 but I couldn't reproduce it locally. The failing example has nothing to do with Default. This commit fixes the build: a531c48

P.s. May or may not be related to #776

@milessabin
Copy link
Owner

Could you pull that commit out as a separate PR?

@milessabin milessabin added this to the shapeless-2.3.3 milestone Dec 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants