Upgrade h11 to 0.6.0-dev. #206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the reason support of h11 is still in master branch, we need to install h11 from github.
|
@chhsiao90 help me review this. Any advice will be grateful. |
chhsiao90
reviewed
Oct 27, 2016
| "socks5==0.1.0" | ||
| ], | ||
| dependency_links=[ | ||
| "https://github.com/chhsiao90/h11/tarball/master#egg=h11-0.5.0+dev", | ||
| "https://github.com/njsmith/h11/tarball/master#egg=h11-0.6.0+dev", |
There was a problem hiding this comment.
Is that h11 v0.6.0 release to pypi?
I think maybe there is no need to add dependency_links if there is h11-v0.6.0 on pypi!
There was a problem hiding this comment.
Oh, the reason that I still use the github version is the response.reason. Sadly to say, the pypi version of h11 does not pick that up.
There was a problem hiding this comment.
We may need to wait until the next release of h11. :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade h11 to 0.6.0-dev.
keep_caseparameter.P.S
Since the
response.reasonsupport of h11 is still in master branch,we still need to install it from github.