Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed Logout from Sandbox not working #69 #72

Merged
merged 2 commits into from
May 21, 2018

Conversation

hmuronaka
Copy link
Contributor

No description provided.

@mike4aday mike4aday self-assigned this May 14, 2018
Copy link
Owner

@mike4aday mike4aday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hmuronaka is the host associated value needed at all? What do you think of:

case let .revoke(token):
    guard let host = authData.identityURL.host, let url = URL(string: "https://\(host)/services/oauth2/revoke") else { 
//...

@hmuronaka
Copy link
Contributor Author

I think host parameter of revoke() and refresh() is unnecessary. But I couldn't judge to change method signature ( like from revoke(token, host) to revoke(token).

I fixed it according to your point, is it good?

@mike4aday
Copy link
Owner

Thank you very much @hmuronaka - let me review.

@mike4aday mike4aday merged commit 4789190 into mike4aday:master May 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants