fix issues 113 & 114 #115
Merged
fix issues 113 & 114 #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| fn.apply(emitter, [err, resultantData]); | ||
| if (err || !mapper || !resultantData) return; | ||
|
|
||
| var key = mapper(resultantData); |
There was a problem hiding this comment.
https://github.com/mikaelbr/node-notifier/pull/115/files#diff-50e3aa130a4f97a42ee2cf111c7b1d9dL164
mix EOL here, fixed.
git config --global core.safecrlf true
see: http://adaptivepatchwork.com/2012/03/01/mind-the-end-of-your-line/
|
@mikaelbr Will you merge it? |
|
Sorry about taking so long. Thanks for contributing! |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#114 fixed
#113 fixed